Repository navigation
feat: Minimize number of connections used by parallel reader - #126
Merged
Merged
Conversation
viirya
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #124
Rationale for this change
The current parallel reader implementation opens and closes too many connections to the file system. This can be reduced by using a fixed number of connections which does not exceed the number of threads used by the parallel reader
What changes are included in this PR?
Creates read ranges and assigns consecutive read range to each thread which then opens only one connection to read the ranges it has been assigned.
How are these changes tested?
TPC-DS benchmark queries on AWS/S3.