extract expressions to folders based on spark grouping#1206
Closed
rluvaton wants to merge 19 commits intoapache:mainfrom
Closed
extract expressions to folders based on spark grouping#1206rluvaton wants to merge 19 commits intoapache:mainfrom
rluvaton wants to merge 19 commits intoapache:mainfrom
Conversation
Member
|
Thanks @rluvaton. This is a good idea. |
rluvaton
changed the title
Member
Author
|
Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location |
Member
Awesome. I plan on reviewing this later this week. |
Member
|
@rluvaton I think that this looks great but it is challenging to really review the PR with so many changes.
What do you think about breaking this down into some smaller PRs that are easier to review? For example, maybe the first PR just moves string expressions. |
Member
Author
|
No problem |
This was referenced Jan 5, 2025
This was referenced Jan 5, 2025
Member
Author
Member
|
@rluvaton ok to close this PR now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark
ExpressionDescriptiongrouppropertyWhat changes are included in this PR?
just reorder files and extract functions there are no logic changes
How are these changes tested?
Existing tests