You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was reviewing the abs logic as part of #638 and noticed that it seems incorrect.
In the following code, when running in Legacy mode, it looks like we return the original array if any of the values cause an overflow. What we should be doing instead is returning the original value for the items in the input array that would cause overflow but return the abs of the other values.
Tests are passing, so I may just be misunderstanding something here.
Activity
andygrove commentedon Jul 8, 2024
I added tests in #638 that confirm the bug
vaibhawvipul commentedon Jul 9, 2024
I will work on this after #638 is merged.
andygrove commentedon Jul 20, 2024
this is a duplicate of #666