You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Doc] CAST has no explicit TimeType branch (Spark 4.1) #4490
Spark 4.1 introduced TimeType (HH:mm:ss). Spark 4.1's Cast.scala adds many TimeType arms (StringType <-> TimeType, TimeType <-> TimeType, TimeType -> IntegralType / DecimalType, etc.). CometCast.isSupported has no TimeType arm at all, so every TimeType-involving cast falls into the default case _ => unsupported(fromType, toType) and falls back to Spark.
The fallback is correct, but it is implicit, and getUnsupportedReasons() on CometCast does not enumerate TimeType as one of the unsupported branches, so the auto-generated compatibility guide doesn't mention it.
Surfaced by the cast audit (collection PR queue).
Expected behavior
Either:
Add an explicit TimeType arm to CometCast.isSupported that returns Unsupported(Some("Cast to/from TimeType is not yet supported")), OR
Activity
test: pin down CometCast fallback for non-default collated strings
fix: reject casts involving non-default collated strings (apache#5302)