Skip to content

Disable Comet if shuffle manager not registered #3900

Closed

Description

@andygrove

What is the problem the feature request solves?

I wonder if we should consider disabling Comet if the shuffle manager is not registered. I would not expect Comet to provide much benefit.

Describe the potential solution

No response

Additional context

No response

Activity

  1. comphead commented on Apr 8, 2026

    @comphead
    Contributor

    We can probably refine the fallback message explaining benefits of having Comet shuffle. Disable Comet completely because of shuffle sounds too aggressive IMO: for example for scan testing sometimes I disable shuffle intentionally just to capture metrics before shuffle.

  2. andygrove commented on May 6, 2026

    @andygrove
    MemberAuthor

    We can probably refine the fallback message explaining benefits of having Comet shuffle. Disable Comet completely because of shuffle sounds too aggressive IMO: for example for scan testing sometimes I disable shuffle intentionally just to capture metrics before shuffle.

    For testing it makes sense to allow all the combinations. For end user use, I am not so sure

  3. self-assigned this
    on May 6, 2026
  4. added this to the 0.17.0 milestone on May 6, 2026
  5. removed their assignment
    on May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions