Skip to content

Support SubqueryBroadcastExec in Comet #242

Closed

Description

@viirya

What is the problem the feature request solves?

Currently we support BroadcastExchange if it is under BroadcastHashJoin in Comet.

Besides broadcast join, BroadcastExchange can also occur under SubqueryBroadcastExec for dynamic pruning expression. Because Spark BroadcastExchange assumes it is row-based so we cannot simply transform BroadcastExchange under SubqueryBroadcastExec into Comet's broadcast operator.

We need to come out with a Comet SubqueryBroadcastExec which supports Comet's BroadcastExchange.

Describe the potential solution

No response

Additional context

No response

Activity

  1. self-assigned this
    on Oct 2, 2024
  2. added this to the 0.4.0 milestone on Oct 2, 2024
  3. removed this from the 0.4.0 milestone on Oct 25, 2024
  4. removed their assignment
    on Oct 31, 2024
  5. andygrove commented on May 1, 2026

    @andygrove
    Member

    we still have some Spark SQL tests ignored and linked to this issue so we should update those tests before closing. I will do this.

  6. self-assigned this
    on May 1, 2026
  7. added this to the 0.16.0 milestone on May 1, 2026
  8. mbutrovich commented on May 1, 2026

    @mbutrovich
    Contributor

    we still have some Spark SQL tests ignored and linked to this issue so we should update those tests before closing. I will do this.

    My bad. I thought I got all of the subquery/DPP filter related Spark SQL tests. I can take a look on Monday if you don’t beat me to it.

  9. mbutrovich commented on Jun 11, 2026

    @mbutrovich
    Contributor

    Closed by #4178. I don't see any references to this issue in the codebase anymore and I think we're fully exercising this now in Spark SQL tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions