Skip to content

Support BroadcastNestedLoopJoinExec #198

Closed

Description

@singhpk234

What is the problem the feature request solves?

Datafusion supports
Cross and NestedLoop joins as well : https://docs.rs/datafusion-physical-plan/36.0.0/datafusion_physical_plan/joins/index.html

It will really nice if we can add support for it like Hash and SortMergeJoin.

Describe the potential solution

No response

Additional context

SHJ pr

Activity

  1. singhpk234 commented on Mar 12, 2024

    @singhpk234
    Author

    @viirya can i pick this up ?

  2. viirya commented on Mar 12, 2024

    @viirya
    Member

    Sure. I've not begun working on this yet. Which one you will work, NestedLoop or Cross Join? In Spark, they are two difference join operators, I think we should have different tickets for them instead of one.

  3. changed the title [-]Support NestedLoop and Cross Join [/-] [+]Support BroadcastNestedLoopJoinExec[/+] on Mar 12, 2024
  4. singhpk234 commented on Mar 12, 2024

    @singhpk234
    Author

    I can start with BNLJ :) !

  5. singhpk234 commented on Mar 28, 2024

    @singhpk234
    Author

    still working on it, will publish a pr by early next week, apologies for the delay.

  6. viirya commented on Mar 28, 2024

    @viirya
    Member

    No problem. Thank you for working on this.

  7. viirya commented on Apr 5, 2024

    @viirya
    Member

    Note that I found several bugs in current broadcast implementation when trying to enable broadcast by default in #213. Since BroadcastNestedLoopJoinExec uses broadcast, I suggest that you can work on the operator after #213 is merged.

  8. singhpk234 commented on Apr 5, 2024

    @singhpk234
    Author

    I suggest that you can work on the operator after #213 is merged

    Ack, let me rebase with this branch meanwhile

  9. coderfender commented on May 6, 2026

    @coderfender
    Contributor

    I will be picking this up

  10. self-assigned this
    on May 6, 2026
  11. coderfender commented on May 6, 2026

    @coderfender
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions