Repository navigation
Enable more DPP Spark SQL tests #1739
Description
What is the problem the feature request solves?
The follow Spark SQL tests should now pass because we fall back to Spark for DPP, so we should stop ignoring them. If they still fail then we should file a specific issue with the root cause and link to that.
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala: IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala: IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantProjectsSuite.scala: IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
Describe the potential solution
Follow the instructions at https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html to update the diffs.
Additional context
No response
Activity
rishvin commentedon May 28, 2025
Hello @andygrove I can work on this.
rishvin commentedon Jun 3, 2025
Opened PR #1838 to address remaining tests in RemoveRedundantProjectsSuite.scala
andygrove commentedon Jun 5, 2025
Fixed in #1831 and #1838