Repository navigation
Simplify Array related functions #1459
Description
Array related functions are creating proto definitions, but we should be able to use generic
https://github.com/apache/datafusion-comet/blob/main/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala#L2116
scalarExprToProtoWithReturnType or scalarExprToProto
Example
#1321 (comment)
Activity
kazantsev-maksim commentedon Mar 6, 2025
I can fix all the already implemented array related functions within the scope of this issue. @kazuyukitanimura
Chore: simplify array related functions impl (#1490)
Chore: simplify array related functions impl (apache#1490)
andygrove commentedon May 6, 2026
The bulk of array serdes in
spark/src/main/scala/org/apache/comet/serde/arrays.scalaalready use the genericscalarFunctionExprToProto/scalarFunctionExprToProtoWithReturnTypehelpers. The remaining cases (ArrayInsert, ArraysZip) require dedicated proto messages and aren't candidates for this simplification, so closing.