-
Notifications
You must be signed in to change notification settings - Fork 286
Closed as not planned
Closed as not planned
Copy link
Labels
enhancementNew feature or requestNew feature or request
Description
What is the problem the feature request solves?
At the moment Comet is trying to support both List and LargeList for handling array functions:
But in the spark the maximal size of any array is equal to java.lang.Integer.MAX_VALUES - 15 and any attempt to create an array of the bigger size will throw an exception:
def cannotCreateArrayWithElementsExceedLimitError(
numElements: Long, additionalErrorMessage: String): SparkRuntimeException = {
new SparkRuntimeException(
errorClass = "_LEGACY_ERROR_TEMP_2176",
messageParameters = Map(
"numElements" -> numElements.toString(),
"maxRoundedArrayLength"-> ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH.toString(),
"additionalErrorMessage" -> additionalErrorMessage))
}Describe the potential solution
Refactoring of all the code in list.rs and drop the support of arrow LargeList. It will simplify an existing code and also simplify resolving of the #1042
Additional context
I can try to make a refactoring and check if tests are passed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request