You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ff694ec
Browse filesBrowse the repository at this point in the historyBrowse files
fix: harden CometObjectStoreRegistry per review feedback
- install the ABFS-aware registry on the initRecordBatchReader
(native_iceberg_compat) path so per-container isolation does not
depend on that context staying private to a single reader
- document the registry as a temporary workaround for
apache/datafusion#23935 so it can be removed at the version bump
- implement deregister_store, the one registry path that bypassed
the Azure store map (previously returned not-implemented)
- use std::sync::RwLock for consistency with the rest of the file
- rename test_s3_store_cache_keys_by_host to
test_non_azure_schemes_ignore_userinfo and note the synthetic URL
shape
Co-Authored-By: Claude Fable 5 <[email protected]>
/// An [`ObjectStoreRegistry`] that keys ABFS stores by the full authority
438
+
/// (`scheme://container@host:port`) instead of DataFusion's `scheme://host:port`.
439
+
///
440
+
/// This is a workaround for `DefaultObjectStoreRegistry`, whose key drops the userinfo
441
+
/// component, collapsing every container in an Azure storage account onto a single store.
442
+
/// Fixed upstream in <https://github.com/apache/datafusion/pull/23935>; this registry can be
443
+
/// removed once Comet is on a DataFusion release containing that fix.
0 commit comments