Skip to content

Commit f4e8e45

Browse files
committed
test: do not assert an unverified cause for the partition-source exclusion
The multi-byte string column is out of the write test's partition spec because the test failed on the Linux CI runners with it in, not because the platform-charset mechanism the comment claimed has been demonstrated -- it does not reproduce locally, including with sun.jnu.encoding forced to US-ASCII.
1 parent 3dc1a2d commit f4e8e45

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎spark/src/test/scala/org/apache/comet/CometIcebergSystemFunctionSuite.scala‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,11 @@ class CometIcebergSystemFunctionSuite
192192
val table = s"$catalog.db.hidden_partitioning"
193193
// No `write.distribution-mode`: Iceberg picks hash distribution for a partitioned table,
194194
// which plans a shuffle and a local sort on the partition transforms. The string column is
195-
// deliberately not a partition source: its multi-byte values would land in partition
196-
// directory names, which iceberg-java reads back through the JVM's platform charset.
195+
// deliberately not a partition source: with it in the spec this test failed on the Linux
196+
// CI runners with a missing data file, which does not reproduce locally, so the multi-byte
197+
// values it would put in partition directory names stay out of the spec until that is
198+
// understood. `bucket` and `truncate` over strings are covered by the comparison, filter,
199+
// sort, and shuffle tests above.
197200
sql(s"""
198201
CREATE TABLE $table (i32 INT, i64 BIGINT, ts TIMESTAMP, dt DATE)
199202
USING iceberg

0 commit comments

Comments
 (0)