Skip to content

Commit f23556e

Browse files
committed
fix: discard native UDF registration results explicitly for the strict-warnings build
`spark.udf.register` returns the registered `UserDefinedFunction` and `ConcurrentHashMap.put` returns the previous value. Both were discarded implicitly at the end of a `Unit` method, which `-Ywarn-value-discard` under `-Pstrict-warnings` rejects as `discarded non-Unit value`. The fatal error also cut scalac short, which is where the job's four errors in untouched shuffle files came from.
1 parent 74d7560 commit f23556e

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎spark/src/main/scala/org/apache/comet/udf/CometNativeUDF.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,6 @@ object CometNativeUDF {
164164
"or open a feature request to extend stub coverage.")
165165
}
166166
val finalUdf = if (deterministic) u else u.asNondeterministic()
167-
spark.udf.register(name, finalUdf)
167+
val _ = spark.udf.register(name, finalUdf)
168168
}
169169
}

‎spark/src/main/scala/org/apache/comet/udf/CometNativeUdfRegistry.scala‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ class CometNativeUdfRegistry {
3838
private val byName = new ConcurrentHashMap[String, NativeUdfMetadata]()
3939

4040
/** Register or replace metadata for a name. */
41-
def register(name: String, meta: NativeUdfMetadata): Unit =
42-
byName.put(name, meta)
41+
def register(name: String, meta: NativeUdfMetadata): Unit = {
42+
val _ = byName.put(name, meta)
43+
}
4344

4445
/** Return metadata for a name, if registered. */
4546
def get(name: String): Option[NativeUdfMetadata] =

0 commit comments

Comments
 (0)