Repository navigation
Commit 94aaa19
committed
test: cover WindowAggExec, nulls, descending keys and the collated fallback
From review:
- The cache test also runs a frame up to UNBOUNDED FOLLOWING, which runs
in WindowAggExec, over a nullable partition key and a descending order
key, so the declared order has to match the cache's.
- The planner test covers both window operators through the partition
order lookup they share, since WindowAggExec fails only when its stream
starts, not in partition_by_sort_keys.
- A Spark 4.x test checks that a window over a cache sorted by a collated
key stays in Spark for the new reason and returns Spark's rows.
- The debugging guide's window snippet builds the operators over `input`.1 parent 8bc8908 commit 94aaa19
3 files changed
Lines changed: 109 additions & 56 deletions
File tree
- docs/source/contributor-guide
- native/core/src/execution
- spark/src/test/scala/org/apache/comet/exec
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | | - | |
| 263 | + | |
| 264 | + | |
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
| |||
271 | 272 | | |
272 | 273 | | |
273 | 274 | | |
274 | | - | |
| 275 | + | |
275 | 276 | | |
276 | 277 | | |
277 | 278 | | |
278 | 279 | | |
279 | 280 | | |
280 | 281 | | |
281 | | - | |
| 282 | + | |
282 | 283 | | |
283 | 284 | | |
284 | 285 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4337 | 4337 | | |
4338 | 4338 | | |
4339 | 4339 | | |
4340 | | - | |
| 4340 | + | |
4341 | 4341 | | |
4342 | | - | |
| 4342 | + | |
| 4343 | + | |
4343 | 4344 | | |
4344 | 4345 | | |
4345 | 4346 | | |
| |||
4351 | 4352 | | |
4352 | 4353 | | |
4353 | 4354 | | |
4354 | | - | |
| 4355 | + | |
4355 | 4356 | | |
4356 | 4357 | | |
4357 | 4358 | | |
| |||
4386 | 4387 | | |
4387 | 4388 | | |
4388 | 4389 | | |
4389 | | - | |
| 4390 | + | |
4390 | 4391 | | |
4391 | 4392 | | |
4392 | 4393 | | |
| |||
4441 | 4442 | | |
4442 | 4443 | | |
4443 | 4444 | | |
4444 | | - | |
4445 | | - | |
| 4445 | + | |
| 4446 | + | |
4446 | 4447 | | |
4447 | 4448 | | |
4448 | 4449 | | |
4449 | | - | |
| 4450 | + | |
4450 | 4451 | | |
4451 | 4452 | | |
4452 | 4453 | | |
| |||
4458 | 4459 | | |
4459 | 4460 | | |
4460 | 4461 | | |
4461 | | - | |
4462 | | - | |
4463 | | - | |
4464 | | - | |
4465 | | - | |
4466 | | - | |
4467 | | - | |
4468 | | - | |
4469 | | - | |
4470 | | - | |
4471 | | - | |
4472 | | - | |
4473 | | - | |
4474 | | - | |
4475 | | - | |
4476 | | - | |
4477 | | - | |
4478 | | - | |
4479 | | - | |
4480 | | - | |
4481 | | - | |
4482 | | - | |
4483 | | - | |
4484 | | - | |
4485 | | - | |
4486 | | - | |
4487 | | - | |
4488 | | - | |
4489 | | - | |
4490 | | - | |
4491 | | - | |
4492 | | - | |
4493 | | - | |
| 4462 | + | |
| 4463 | + | |
| 4464 | + | |
| 4465 | + | |
| 4466 | + | |
| 4467 | + | |
| 4468 | + | |
| 4469 | + | |
| 4470 | + | |
| 4471 | + | |
| 4472 | + | |
| 4473 | + | |
| 4474 | + | |
| 4475 | + | |
| 4476 | + | |
| 4477 | + | |
| 4478 | + | |
| 4479 | + | |
| 4480 | + | |
| 4481 | + | |
| 4482 | + | |
| 4483 | + | |
| 4484 | + | |
| 4485 | + | |
| 4486 | + | |
| 4487 | + | |
| 4488 | + | |
| 4489 | + | |
| 4490 | + | |
| 4491 | + | |
| 4492 | + | |
| 4493 | + | |
| 4494 | + | |
| 4495 | + | |
| 4496 | + | |
| 4497 | + | |
4494 | 4498 | | |
4495 | 4499 | | |
4496 | 4500 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3695 | 3695 | | |
3696 | 3696 | | |
3697 | 3697 | | |
3698 | | - | |
| 3698 | + | |
| 3699 | + | |
| 3700 | + | |
| 3701 | + | |
| 3702 | + | |
| 3703 | + | |
| 3704 | + | |
| 3705 | + | |
| 3706 | + | |
| 3707 | + | |
| 3708 | + | |
| 3709 | + | |
| 3710 | + | |
3699 | 3711 | | |
3700 | 3712 | | |
3701 | 3713 | | |
| |||
3705 | 3717 | | |
3706 | 3718 | | |
3707 | 3719 | | |
3708 | | - | |
| 3720 | + | |
3709 | 3721 | | |
3710 | | - | |
| 3722 | + | |
3711 | 3723 | | |
3712 | 3724 | | |
3713 | 3725 | | |
3714 | | - | |
3715 | | - | |
3716 | | - | |
3717 | | - | |
3718 | | - | |
3719 | | - | |
3720 | | - | |
3721 | | - | |
3722 | | - | |
3723 | | - | |
| 3726 | + | |
| 3727 | + | |
| 3728 | + | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
| 3736 | + | |
3724 | 3737 | | |
3725 | 3738 | | |
3726 | 3739 | | |
| |||
3729 | 3742 | | |
3730 | 3743 | | |
3731 | 3744 | | |
| 3745 | + | |
| 3746 | + | |
| 3747 | + | |
| 3748 | + | |
| 3749 | + | |
| 3750 | + | |
| 3751 | + | |
| 3752 | + | |
| 3753 | + | |
| 3754 | + | |
| 3755 | + | |
| 3756 | + | |
| 3757 | + | |
| 3758 | + | |
| 3759 | + | |
| 3760 | + | |
| 3761 | + | |
| 3762 | + | |
| 3763 | + | |
| 3764 | + | |
| 3765 | + | |
| 3766 | + | |
| 3767 | + | |
| 3768 | + | |
| 3769 | + | |
| 3770 | + | |
| 3771 | + | |
| 3772 | + | |
| 3773 | + | |
| 3774 | + | |
| 3775 | + | |
| 3776 | + | |
| 3777 | + | |
| 3778 | + | |
| 3779 | + | |
3732 | 3780 | | |
3733 | 3781 | | |
3734 | 3782 | | |
| |||
0 commit comments