Skip to content

Commit 8e8513a

Browse files
committed
docs: link the iceberg-rust issue for its truncating day
apache/iceberg-rust#3315 reports the bug that moves some pre-epoch timestamps into the next day, so the next reader can tell when the special case can go.
1 parent c5d00f7 commit 8e8513a

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎native/core/src/execution/operators/iceberg_partition_value.rs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ use iceberg::{Error, ErrorKind, Result};
5151
/// partitions (apache/datafusion-comet#6426).
5252
/// - `day` moves a timestamp from the last second of a day before 1969-12-31 into the next day,
5353
/// unless its microsecond of second is 0 or 999999: it takes the whole seconds with a truncating
54-
/// division and the microseconds with a flooring one.
54+
/// division and the microseconds with a flooring one (apache/iceberg-rust#3315).
5555
///
5656
/// A partition value that differs from the sort key can also fail a clustered write, which rejects
5757
/// a row whose partition it has already closed. Everywhere else the two implementations agree, so
@@ -439,8 +439,9 @@ mod tests {
439439
let label = format!("{transform} of {}", source.data_type());
440440
assert_eq!(&comet[i], java, "{label}");
441441
// The reason Comet computes these: iceberg-rust floors the first two rows, and its
442-
// `day` moves the last two into 1969-12-31. If this starts failing, iceberg-rust's
443-
// transforms have changed and delegating needs another look.
442+
// `day` moves the last two into 1969-12-31 (apache/iceberg-rust#3315). If this
443+
// starts failing, iceberg-rust's transforms have changed and delegating needs
444+
// another look.
444445
assert_eq!(&iceberg_rust[i], rust, "iceberg-rust's {label}");
445446
}
446447
}

0 commit comments

Comments
 (0)