Skip to content

Commit 78e60cd

Browse files
test: tighten map lookup dispatch assertions and documentation
1 parent 3d3cbea commit 78e60cd

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎spark/src/main/scala/org/apache/comet/serde/arrays.scala‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ object CometElementAt extends CometExpressionSerde[ElementAt] with CodegenDispat
637637
private val argumentsReason = "unsupported arguments for ElementAt"
638638

639639
override def getUnsupportedReasons(): Seq[String] =
640-
MapKeySupport.unsupportedReasons ++ Seq(eagerIndexReason, inputTypeReason, argumentsReason)
640+
MapKeySupport.unsupportedReasons :+ eagerIndexReason
641641

642642
/** True when `convert` has to wrap the lookup to reproduce Spark's NULL short-circuit. */
643643
private def needsNullGuard(expr: ElementAt): Boolean =

‎spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ import org.apache.spark.sql.types.BinaryType
3131
import org.apache.comet.CometSparkSessionExtensions.isSpark40Plus
3232
import org.apache.comet.testing.{DataGenOptions, ParquetGenerator, SchemaGenOptions}
3333

34-
class CometMapExpressionSuite extends CometTestBase with CometCodegenAssertions {
34+
class CometMapExpressionSuite extends CometTestBase {
3535

3636
private def checkMapLookupDispatch(query: String): Unit = {
37-
assertCodegenRan {
38-
checkSparkAnswerAndOperator(query)
39-
}
37+
checkSparkAnswerAndImpl(query, native = Seq.empty, dispatched = Seq("element_at"))
4038
}
4139

4240
test("map lookup preserves fallback when codegen dispatch is disabled") {

0 commit comments

Comments
 (0)