Repository navigation
Commit 6db6c1b
committed
fix: treat the NO_CODEGEN factory mode as codegen off for the decimal SUM fallback
CollapseCodegenStages skips whole-stage codegen when spark.sql.codegen.factoryMode is
NO_CODEGEN, and the interpreted projection then writes each update into the UnsafeRow
buffer that latches on overflow, so the fallback reads the mode the same way.1 parent 90cfbe6 commit 6db6c1b
3 files changed
Lines changed: 18 additions & 7 deletions
File tree
- docs/source/user-guide/latest/compatibility
- spark/src
- main/scala/org/apache/spark/sql/comet
- test/scala/org/apache/comet/exec
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
2230 | 2230 | | |
2231 | 2231 | | |
2232 | 2232 | | |
2233 | | - | |
2234 | | - | |
| 2233 | + | |
| 2234 | + | |
| 2235 | + | |
2235 | 2236 | | |
| 2237 | + | |
| 2238 | + | |
2236 | 2239 | | |
2237 | 2240 | | |
2238 | 2241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1600 | 1600 | | |
1601 | 1601 | | |
1602 | 1602 | | |
1603 | | - | |
1604 | | - | |
| 1603 | + | |
| 1604 | + | |
1605 | 1605 | | |
1606 | 1606 | | |
1607 | 1607 | | |
| |||
1629 | 1629 | | |
1630 | 1630 | | |
1631 | 1631 | | |
| 1632 | + | |
| 1633 | + | |
| 1634 | + | |
| 1635 | + | |
| 1636 | + | |
| 1637 | + | |
| 1638 | + | |
1632 | 1639 | | |
1633 | 1640 | | |
1634 | 1641 | | |
| |||
0 commit comments