You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5fa47b2
Browse filesBrowse the repository at this point in the historyBrowse files
Merge remote-tracking branch 'apache/main' into andygrove/issue-6913-fix
Keep the scheduler probe from #6601 out of the way of a direct shuffle read: the probe's RDD
hides the shuffle RDD that resolveInputObjects needs, so a write with a ShuffleScan leaf takes
the shuffle RDD as it is and calls the probe's beforeInput at the top of
CometIcebergWriteRDD.compute, ahead of the shuffle fetch. A child that is read over FFI still
goes through the probe's RDD.
Tests: the direct-read write test covers date, timestamp, timestamp_ntz, decimal, binary,
boolean and float columns with NaN, -0.0, infinities and nulls, asserts that the coalesced case
has a coalesced AQEShuffleReadExec, and adds a case with mostly empty reducer partitions. A new
test checks that the probe runs for every task of a write that reads a shuffle directly.
Copy file name to clipboardExpand all lines: .ai/skills/review-comet-pr/SKILL.md
+15-10Lines changed: 15 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
---
2
2
name: review-comet-pr
3
-
description: Use when reviewing a DataFusion Comet pull request. Covers the workflow that applies to every PR and routes to the area-specific review skills for expressions, FFI, memory management, shuffle, and Iceberg writes. Provides guidance to a human reviewer rather than posting comments.
3
+
description: Use when reviewing a DataFusion Comet pull request. Covers the workflow that applies to every PR and routes to the area-specific review skills for expressions, FFI, memory management, shuffle, Iceberg writes, and documentation. Provides guidance to a human reviewer rather than posting comments.
0 commit comments