Skip to content

Commit 4958915

Browse files
authored
test: unignore InjectRuntimeFilterSuite tests gated on issue #242 (#4178)
1 parent 425f9c9 commit 4958915

3 files changed

Lines changed: 0 additions & 72 deletions

File tree

‎dev/diffs/3.4.3.diff‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -657,30 +657,6 @@ index 00000000000..5691536c114
657657
+ }
658658
+ }
659659
+}
660-
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
661-
index fda442eeef0..1b69e4f280e 100644
662-
--- a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
663-
+++ b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
664-
@@ -468,7 +468,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
665-
}
666-
667-
test("Runtime bloom filter join: do not add bloom filter if dpp filter exists " +
668-
- "on the same column") {
669-
+ "on the same column",
670-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
671-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
672-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
673-
assertDidNotRewriteWithBloomFilter("select * from bf5part join bf2 on " +
674-
@@ -477,7 +478,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
675-
}
676-
677-
test("Runtime bloom filter join: add bloom filter if dpp filter exists on " +
678-
- "a different column") {
679-
+ "a different column",
680-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
681-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
682-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
683-
assertRewroteWithBloomFilter("select * from bf5part join bf2 on " +
684660
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
685661
index 1792b4c32eb..1616e6f39bd 100644
686662
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala

‎dev/diffs/4.0.2.diff‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -788,30 +788,6 @@ index 00000000000..5691536c114
788788
+ }
789789
+ }
790790
+}
791-
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
792-
index 7d7185ae6c1..442a5bddeb8 100644
793-
--- a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
794-
+++ b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
795-
@@ -442,7 +442,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
796-
}
797-
798-
test("Runtime bloom filter join: do not add bloom filter if dpp filter exists " +
799-
- "on the same column") {
800-
+ "on the same column",
801-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
802-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
803-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
804-
assertDidNotRewriteWithBloomFilter("select * from bf5part join bf2 on " +
805-
@@ -451,7 +452,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
806-
}
807-
808-
test("Runtime bloom filter join: add bloom filter if dpp filter exists on " +
809-
- "a different column") {
810-
+ "a different column",
811-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
812-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
813-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
814-
assertRewroteWithBloomFilter("select * from bf5part join bf2 on " +
815791
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
816792
index 53e47f428c3..a55d8f0c161 100644
817793
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala

‎dev/diffs/4.1.1.diff‎

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -982,30 +982,6 @@ index 00000000000..5691536c114
982982
+ }
983983
+ }
984984
+}
985-
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
986-
index 7d7185ae6c1..442a5bddeb8 100644
987-
--- a/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
988-
+++ b/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
989-
@@ -442,7 +442,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
990-
}
991-
992-
test("Runtime bloom filter join: do not add bloom filter if dpp filter exists " +
993-
- "on the same column") {
994-
+ "on the same column",
995-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
996-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
997-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
998-
assertDidNotRewriteWithBloomFilter("select * from bf5part join bf2 on " +
999-
@@ -451,7 +452,8 @@ class InjectRuntimeFilterSuite extends QueryTest with SQLTestUtils with SharedSp
1000-
}
1001-
1002-
test("Runtime bloom filter join: add bloom filter if dpp filter exists on " +
1003-
- "a different column") {
1004-
+ "a different column",
1005-
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
1006-
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key -> "3000",
1007-
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
1008-
assertRewroteWithBloomFilter("select * from bf5part join bf2 on " +
1009985
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
1010986
index 53e47f428c3..a55d8f0c161 100644
1011987
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala

0 commit comments

Comments
 (0)