Skip to content

Commit 46774ca

Browse files
committed
test: regenerate TPC-DS plans without the divisor normalization
Without NormalizeNaNAndZero around float divisors, the 11 approved plans that hold a float division in a Project or Filter count one native expression fewer, and q78 no longer lists knownfloatingpointnormalized and normalizenanandzero among its dispatched expressions. Regenerated on Spark 3.4, 3.5, 4.0, 4.1 and 4.2; 4.1 and 4.2 need no override.
1 parent 4c4f979 commit 46774ca

11 files changed

Lines changed: 13 additions & 13 deletions

File tree

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q83/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,4 +101,4 @@ CometColumnarToRow
101101
+- CometFilter
102102
+- CometNativeScan parquet spark_catalog.default.date_dim
103103

104-
Comet accelerated 52 out of 52 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 0 codegen dispatch.
104+
Comet accelerated 52 out of 52 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 11 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark4_0/q83.ansi/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,4 +101,4 @@ CometColumnarToRow
101101
+- CometFilter
102102
+- CometNativeScan parquet spark_catalog.default.date_dim
103103

104-
Comet accelerated 52 out of 52 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 0 codegen dispatch.
104+
Comet accelerated 52 out of 52 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 11 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q21/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ CometColumnarToRow
2727
+- CometFilter
2828
+- CometNativeScan parquet spark_catalog.default.date_dim
2929

30-
Comet accelerated 24 out of 24 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 13 native, 0 codegen dispatch.
30+
Comet accelerated 24 out of 24 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q34/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ CometColumnarToRow
3737
+- CometFilter
3838
+- CometNativeScan parquet spark_catalog.default.customer
3939

40-
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 15 native, 0 codegen dispatch.
40+
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 14 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q39a/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,4 @@ CometColumnarToRow
6060
+- CometFilter
6161
+- CometNativeScan parquet spark_catalog.default.date_dim
6262

63-
Comet accelerated 46 out of 46 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 11 native, 0 codegen dispatch.
63+
Comet accelerated 46 out of 46 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 10 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q39b/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,4 @@ CometColumnarToRow
6060
+- CometFilter
6161
+- CometNativeScan parquet spark_catalog.default.date_dim
6262

63-
Comet accelerated 46 out of 46 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 11 native, 0 codegen dispatch.
63+
Comet accelerated 46 out of 46 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 10 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q73/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ CometColumnarToRow
3737
+- CometFilter
3838
+- CometNativeScan parquet spark_catalog.default.customer
3939

40-
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 15 native, 0 codegen dispatch.
40+
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 14 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q78/extended.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
CometColumnarToRow
22
+- CometTakeOrderedAndProject [COMET-INFO: JVM codegen dispatcher: add, cast, coalesce, divide, round]
3-
+- CometProject [COMET-INFO: JVM codegen dispatcher: add, cast, coalesce, divide, knownfloatingpointnormalized, normalizenanandzero, round]
3+
+- CometProject [COMET-INFO: JVM codegen dispatcher: add, cast, coalesce, divide, round]
44
+- CometSortMergeJoin
55
:- CometProject
66
: +- CometSortMergeJoin
@@ -76,4 +76,4 @@ CometColumnarToRow
7676
+- CometFilter
7777
+- CometNativeScan parquet spark_catalog.default.date_dim
7878

79-
Comet accelerated 65 out of 65 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 7 codegen dispatch.
79+
Comet accelerated 65 out of 65 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 5 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,4 +114,4 @@ CometColumnarToRow
114114
+- CometFilter
115115
+- CometNativeScan parquet spark_catalog.default.date_dim
116116

117-
Comet accelerated 62 out of 62 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 12 native, 0 codegen dispatch.
117+
Comet accelerated 62 out of 62 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 11 native, 0 codegen dispatch.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q34/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ CometColumnarToRow
3737
+- CometFilter
3838
+- CometNativeScan parquet spark_catalog.default.customer
3939

40-
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 15 native, 0 codegen dispatch.
40+
Comet accelerated 33 out of 33 eligible operators (100%). Final plan contains 1 transitions between Spark and Comet. Accelerated expressions: 14 native, 0 codegen dispatch.

0 commit comments

Comments
 (0)