Skip to content

Commit 267b5ce

Browse files
committed
test: move the NullType composition sweep and benchmark to follow-ups
Review asked to land CometNullTypeCompositionSuite and CometNullTypeColumnsBenchmark separately: the sweep took about 8 minutes on every PR profile while the SQL file fixtures already pin each gated shape, and it belongs with the fuzz suites. Remove both, with the suite's entries in the Linux and macOS PR workflows (dev/ci/check-suites.py requires every suite in both) and the CometBenchmarkBase changes only the benchmark used. Drop the second case of test_literal_to_list_with_only_empty_children. Since #4715, main covers that input in test_literal_to_list_with_empty_nested_children_non_nullable. The [[], null] case, which main does not cover, stays. Assisted-by: Claude Code (claude-opus-5-5)
1 parent 90d02eb commit 267b5ce

6 files changed

Lines changed: 36 additions & 1520 deletions

File tree

‎.github/workflows/pr_build_linux.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,6 @@ jobs:
619619
org.apache.comet.serde.CometLiteralSuite
620620
org.apache.comet.serde.QueryPlanSerdeSuite
621621
org.apache.comet.CometFallbackInvarianceSuite
622-
org.apache.comet.CometNullTypeCompositionSuite
623622
fail-fast: false
624623
name: ${{ matrix.profile.name }} [${{ matrix.suite.name }}]
625624
runs-on: ubuntu-24.04

‎.github/workflows/pr_build_macos.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@ jobs:
323323
org.apache.comet.serde.CometLiteralSuite
324324
org.apache.comet.serde.QueryPlanSerdeSuite
325325
org.apache.comet.CometFallbackInvarianceSuite
326-
org.apache.comet.CometNullTypeCompositionSuite
327326
328327
fail-fast: false
329328
name: ${{ matrix.os }}/${{ matrix.profile.name }} [${{ matrix.suite.name }}]

‎native/core/src/execution/planner.rs‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -6589,48 +6589,6 @@ mod tests {
65896589
assert!(list.value(0).is_empty());
65906590
assert!(list.is_null(1));
65916591

6592-
// [[[]], [[[1]]]] with every declared field non-nullable: the first child has no values
6593-
// below its own level, the second has. Both must come out as the same type, or
6594-
// concatenating them fails.
6595-
let list_of = |dt: DataType| DataType::List(Arc::new(Field::new("item", dt, false)));
6596-
let one = ListLiteral {
6597-
int_values: vec![1],
6598-
null_mask: vec![true],
6599-
..Default::default()
6600-
};
6601-
let data = ListLiteral {
6602-
list_values: vec![
6603-
ListLiteral {
6604-
list_values: vec![ListLiteral::default()],
6605-
null_mask: vec![true],
6606-
..Default::default()
6607-
},
6608-
ListLiteral {
6609-
list_values: vec![ListLiteral {
6610-
list_values: vec![one],
6611-
null_mask: vec![true],
6612-
..Default::default()
6613-
}],
6614-
null_mask: vec![true],
6615-
..Default::default()
6616-
},
6617-
],
6618-
null_mask: vec![true, true],
6619-
..Default::default()
6620-
};
6621-
let nested_type = list_of(list_of(list_of(list_of(DataType::Int32))));
6622-
6623-
let array = literal_to_array_ref(nested_type, data)?;
6624-
let list = array.as_any().downcast_ref::<ListArray>().unwrap();
6625-
assert_eq!(list.len(), 2);
6626-
assert!(list
6627-
.value(0)
6628-
.as_any()
6629-
.downcast_ref::<ListArray>()
6630-
.unwrap()
6631-
.value(0)
6632-
.is_empty());
6633-
assert_eq!(list.value(1).len(), 1);
66346592
Ok(())
66356593
}
66366594

0 commit comments

Comments
 (0)