You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 20dfd08
Browse filesBrowse the repository at this point in the historyBrowse files
review: benchmark the cache codec, test an unknown codec, fix non-clean shading
The codec table in the docs had zstd beating `none` on write and read
speed as well as footprint, and it did not come from a committed
benchmark. CometInMemoryCacheBenchmark now has a codec axis over the flat
relation -- materialize time, footprint, and narrow and full reads -- and
with each case warmed up, `none` is faster at everything but footprint:
1091 ms against 1503 ms to materialize and 63 ms against 296 ms for a full
read, at 315 MiB against 55 MiB. zstd stays the default, on footprint
grounds, and the docs and the compression.codec doc string now say so.
Every table on the docs page is regenerated from one run.
The unknown body-compression byte branch in readCodec had no test. A
helper now assembles a payload whose body records a byte no Arrow codec
owns, and a test asserts the read fails naming it.
Any build without `clean` in which no class had changed failed in shade
with a duplicate META-INF/services entry: the jar plugin leaves the
previously shaded jar in place, and the services transformer then writes
the relocated codec registration twice. Exclude the already relocated
copy on the way in.
Also fixes a collation-test comment that no longer described its
assertion.
0 commit comments