Repository navigation
Commit 1bb942a
committed
fix: fall back on a collated window key only over a trusted order
Falling back hands the rows to Spark's window, which trusts the order the
input reports. Over an order mayReportFalseOrder doubts, such as a native
nested loop join's, that grouped the rows wrongly, so the window now stays
native there, as on main, and the native window rejects the input. The
outer join regression test partitions by k, which Spark reports through
the alias a, so it needs the order declared next to the join's.1 parent ee88fd9 commit 1bb942a
2 files changed
Lines changed: 20 additions & 14 deletions
File tree
- spark/src
- main/scala/org/apache/spark/sql/comet
- test/scala/org/apache/comet/exec
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
78 | 87 | | |
79 | 88 | | |
80 | 89 | | |
81 | 90 | | |
82 | | - | |
| 91 | + | |
83 | 92 | | |
84 | 93 | | |
85 | 94 | | |
| |||
94 | 103 | | |
95 | 104 | | |
96 | 105 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
103 | 109 | | |
104 | | - | |
105 | | - | |
106 | | - | |
| 110 | + | |
107 | 111 | | |
108 | 112 | | |
109 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3860 | 3860 | | |
3861 | 3861 | | |
3862 | 3862 | | |
3863 | | - | |
3864 | | - | |
| 3863 | + | |
| 3864 | + | |
| 3865 | + | |
| 3866 | + | |
3865 | 3867 | | |
3866 | 3868 | | |
3867 | 3869 | | |
3868 | 3870 | | |
3869 | | - | |
| 3871 | + | |
3870 | 3872 | | |
3871 | 3873 | | |
3872 | 3874 | | |
3873 | 3875 | | |
3874 | | - | |
| 3876 | + | |
3875 | 3877 | | |
3876 | 3878 | | |
3877 | 3879 | | |
| |||
0 commit comments