Repository navigation
Commit 0e66bc0
committed
fix: drop the unused SparkConf import and narrow the min/max workaround
The suite no longer overrides sparkConf, so its SparkConf import failed
Scalafix and the strict-warnings build. Reformat a CometExecRule comment
that Spotless rejected.
The three-config min/max workaround only keeps the decode out of the
query when the cast is the aggregate's own argument. A cast in a
projection below the aggregate runs natively and decodes first, so the
guide now says so and keeps disabling Comet as the general answer.1 parent 5104964 commit 0e66bc0
3 files changed
Lines changed: 9 additions & 6 deletions
File tree
- docs/source/user-guide/latest/compatibility
- spark/src
- main/scala/org/apache/comet/rules
- test/scala/org/apache/comet
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | | - | |
128 | | - | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
129 | 133 | | |
130 | 134 | | |
131 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1540 | 1540 | | |
1541 | 1541 | | |
1542 | 1542 | | |
1543 | | - | |
1544 | | - | |
| 1543 | + | |
| 1544 | + | |
1545 | 1545 | | |
1546 | 1546 | | |
1547 | 1547 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| |||
0 commit comments