@@ -1769,11 +1769,9 @@ impl PhysicalPlanner {
17691769 . iter ( )
17701770 . map ( |( k, v) | ( k. clone ( ) , v. clone ( ) ) )
17711771 . collect ( ) ;
1772- // Rewrite opted-in S3-compliant alias schemes (`fs.comet.s3Compliant.schemes`,
1773- // carried in catalog_properties) to canonical `s3://bucket/key`, so
1774- // `storage_factory_for` routes to the S3 backend instead of the LocalFs fallback it
1775- // picks for schemes without a `://` authority. The single-slash `blob:/bucket/key`
1776- // form is handled defensively; real object-store metadata locations are two-slash.
1772+ // Rewrite opted-in aliases (carried in catalog_properties) to `s3://bucket/key` so
1773+ // `storage_factory_for` routes to the S3 backend, not the LocalFs fallback it picks
1774+ // for schemes without a `://` authority. Single-slash form handled defensively.
17771775 let metadata_location = normalize_object_store_url_string (
17781776 & common. metadata_location ,
17791777 & common. catalog_properties ,
@@ -4059,11 +4057,9 @@ fn parse_file_scan_tasks_from_common(
40594057 } ;
40604058
40614059 Ok ( iceberg:: scan:: FileScanTaskDeleteFile {
4062- // Delete-file path: safe to rewrite an opted-in alias to s3:// (unlike
4063- // `data_file_path`), since it only locates the delete file for fetching and is
4064- // never matched against a data-file identity. The normalizer preserves the raw
4065- // object key so opendal does not double-encode it, and handles the single-slash
4066- // form defensively.
4060+ // Safe to rewrite an opted-in alias here (unlike `data_file_path`): this only
4061+ // locates the delete file, never matched against a data-file identity. The
4062+ // normalizer preserves the raw key so opendal does not double-encode it.
40674063 file_path : normalize_object_store_url_string (
40684064 & del. file_path ,
40694065 & proto_common. catalog_properties ,
@@ -4288,12 +4284,11 @@ fn parse_file_scan_tasks_from_common(
42884284
42894285 Ok ( iceberg:: scan:: FileScanTask {
42904286 file_size_in_bytes : proto_task. file_size_in_bytes ,
4291- // Keep the RAW data-file path -- do NOT rewrite blob:// to s3://. iceberg-rust
4292- // matches positional deletes by comparing this string against the data-file path
4293- // recorded inside the delete file (as Iceberg wrote it), so changing the scheme
4294- // here silently drops deletes. The S3 backend opens a raw blob:// path fine (it
4295- // takes the bucket from the host and slices the key out verbatim), and
4296- // `metadata_location` (normalized above) already selected the S3 storage factory.
4287+ // RAW data-file path -- do NOT rewrite the alias to s3://. iceberg-rust matches
4288+ // positional deletes by comparing this against the path recorded inside the delete
4289+ // file, so changing the scheme drops deletes. The S3 backend opens a raw alias path
4290+ // fine (bucket from host, key sliced verbatim), and `metadata_location` above
4291+ // already selected the storage factory.
42974292 data_file_path : proto_task. data_file_path . clone ( ) ,
42984293 start : proto_task. start ,
42994294 length : proto_task. length ,
0 commit comments