Port ArrayRepeat to functions-array subcrate#9568
Merged
jayzhan211 merged 1 commit intoapache:mainfrom Mar 13, 2024
erenavsarogullari:Issue-9565
Merged
Port ArrayRepeat to functions-array subcrate#9568jayzhan211 merged 1 commit intoapache:mainfrom erenavsarogullari:Issue-9565
ArrayRepeat to functions-array subcrate#9568jayzhan211 merged 1 commit intoapache:mainfrom
erenavsarogullari:Issue-9565
Conversation
github-actions
bot
added
logical-expr
erenavsarogullari
changed the title
ArrayRepeat to function-arrays subcrateArrayRepeat to functions-array subcrate
comphead
approved these changes
Mar 12, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @erenavsarogullari please check the conflicting files
Member
Author
|
Thanks @jayzhan211 and @comphead for the review. Merge conflicts have just been addressed. |
Member
Author
|
Is it possible to re-trigger the build? |
Contributor
I had re-run it once, but the same error is occured. |
Member
Author
|
@jayzhan211 Thanks for triggering the build and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9565.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
1-
ArrayRepeatis ported tofunctions-arraysubcrate,2- Minor cleanup by removing redundant package definitions.
Are these changes tested?
Yes, all
array.sltbasedarray_repeattests are passed.Are there any user-facing changes?
No