You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lgtm thanks @alamb btw what do you think about adding a mandatory description on the test query and eventually output it?
Thanks @comphead -- I am not quite sure what you mean
Do you mean require a comment on each query that explains what is expected? It sounds reasonable to me, though if we aren't careful we'll end up with comments like # ensure correct output which probably don't add much value
lgtm thanks @alamb btw what do you think about adding a mandatory description on the test query and eventually output it?
Thanks @comphead -- I am not quite sure what you mean
Do you mean require a comment on each query that explains what is expected? It sounds reasonable to me, though if we aren't careful we'll end up with comments like # ensure correct output which probably don't add much value
composing a correct description can be part of review.
composing a correct description can be part of review.
I agree this would be great. I am just wondering how to make it happen -- if the review requires human intervention anyways, I am not sure automation will help 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Minor follow on to #8501 from @razeghi71
Rationale
I think the test added in #8501 would be easier to find if they were in the existing
map.sltfileWhat changes are included in this PR?
map.sltAre these changes tested?
only tests
Are there any user-facing changes?