Add test for DataFrame::write_table#8531
Merged
alamb merged 3 commits intoapache:mainfrom Dec 15, 2023
Merged
Conversation
comphead
reviewed
Dec 13, 2023
| .to_str() | ||
| .expect("Should be a str") | ||
| .to_owned(); | ||
| println!("{name}"); |
comphead
approved these changes
Dec 13, 2023
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm
thanks @devinjdangelo
Contributor
|
Can we add a simpler version to the Datafusion examples? |
Contributor
I filed #8551 to track this (good idea). Thank you @devinjdangelo and @metesynnada |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8530
Rationale for this change
As pointed out by @comphead, we do not currently have a unit test specific to DataFrame::write_table. This PR adds one.
What changes are included in this PR?
Unit test for DataFrame::write_table method, which is very similar to the unit test for DataFrame::write_parquet.
Are these changes tested?
The change is itself a new test.
Are there any user-facing changes?
No