Permit running sqllogictest as a rust test in IDEs (+ use clap for sqllogicttest parsing, accept (and ignore) rust test harness arguments)#8288
Conversation
|
FYI @xudong963 (as you originally filed #4769) and @tustvold (as you originally mentioned #8287) |
|
I worry this might be fragile if IDEs choose to enable other options. I'm curious why you decided against making an explicit binary and then a test target that just calls the binary entrypoint but with no arguments, as was described in the initial ticket? |
I agree it is fragile (but easy to fix)
I tried this approach but then decided on this one because (at least for me in RustRover) I felt it would be easier to use / understand. making a different binary ended up being something like And then when I started trying to add some documents on how to run this command, it got confusing quickly Thus I figured it would be easier to understand if it just looked like the test binary. |
sqllogictest as a rust test in IDEs (+ use clap for sqllogicttest parsing, accept (and ignore) rust test harness arguments)
|
I added some additional warnings in 9506116 to reduce confusion |
Which issue does this PR close?
Closes #8287
Closes #4769
Rationale for this change
Basically I want to be able to run sqllogictest in RustRover more conveniently (and also make it easier for @tustvold to work in DataFusion so he does it more ;) )
In the UI I enter this:

However, what the IDE actually runs is this (notice the new arguments)

What changes are included in this PR?
clapUseClapfor sqllogictest #4769Are these changes tested?
Yes, by existing CI tests
I also tested manually and I can now run these tests just fine in RustRover/ Here is what a session looks like:
Are there any user-facing changes?
No, it is entirely developer facing