Port tests in projection.rs to sqllogictest#8240
Merged
alamb merged 6 commits intoapache:mainfrom Nov 17, 2023
Merged
Conversation
github-actions
bot
added
core
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
PsiACE
force-pushed
the
projection-slt
branch
from
337f9b8 to
672de39
Compare
PsiACE
commented
Nov 16, 2023
Signed-off-by: Chojan Shang <[email protected]>
alamb
approved these changes
Nov 17, 2023
Signed-off-by: Chojan Shang <[email protected]>
Member
Author
I am glad that I have the opportunity to participate in the arrow community again in 2023. I think I will try to do some interesting things. It's also nice to meet you again. |
Contributor
Its great to see you back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8210.
Rationale for this change
Part of #6195.
What changes are included in this PR?
Deleted projection.rs and added test cases in projection.slt.
Are these changes tested?
Yes. I followed the conversion rules.
Due to the fact that the projectioned data files used for testing are from other SQLLogicTest cases and do not exactly match the numbers generated by the original code, some of the test results may differ. However, I believe that they are all within expectations.
Are there any user-facing changes?
No