Implement array_pop_back function #7348
Conversation
github-actions
bot
added
logical-expr
| define_array_slice(list_array, key, extra_key, false) | ||
| } | ||
|
|
||
| pub fn array_pop_back(args: &[ArrayRef]) -> Result<ArrayRef> { |
There was a problem hiding this comment.
@tanruixiang Do you want to implement array_pop_front function (See the ticket: #6996)? It has the similar syntax and it's a quite improvement your contribution in the project.
There was a problem hiding this comment.
Yes, I would love to implement array_pop_front , do I need to implement array_pop_front in this pr? Or in the next pr.
There was a problem hiding this comment.
This is the excellent improvement 🥇! Thank you, @tanruixiang!
cc @alamb @jayzhan211
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
LGTM too -- thank you @tanruixiang
I think this PR just needs to have conflicts resolved and it should be good to merge
Thank you @jayzhan211 and @izveigor for reviews
|
@alamb @jayzhan211 @izveigor Thanks to all for the reviews, the conflict has been resolved! |
|
Thanks @tanruixiang |
4 participants
Which issue does this PR close?
Closes #6997 .
Rationale for this change
see #6997
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?