Minor: Add array / array sqllogic tests for array_contains#6771
Merged
alamb merged 3 commits intoapache:mainfrom Jun 28, 2023
Merged
Minor: Add array / array sqllogic tests for array_contains#6771alamb merged 3 commits intoapache:mainfrom
array_contains#6771alamb merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
Merged
Contributor
Contributor
Author
We should for sure -- I wonder if we can leverage existing .slt files (from sqllite, for example). It would be a good thing / gap to track with tickets |
alamb
force-pushed
the
alamb/array_contains_tests
branch
from
6be5869 to
dd40420
Compare
github-actions
bot
removed
logical-expr
alamb
changed the title
array_containsarray_contains
izveigor
reviewed
Jun 28, 2023
|
|
||
| # array_contains array | ||
|
|
||
| statement ok |
Contributor
There was a problem hiding this comment.
I think it would be better to test nested arrays even more.
izveigor
reviewed
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6709
Rationale for this change
While reviewing #6618 I felt there was a gap in coverage:
What changes are included in this PR?
tests for array functions on array functions
Are these changes tested?
Are there any user-facing changes?