Disable incremental compilation on CI#6688
Merged
alamb merged 1 commit intoapache:mainfrom Jun 15, 2023
Merged
Conversation
Contributor
Author
|
Given I think this PR gives us some more breathing room and doesn't change any code (just the build on CI), I plan to merge it if/when the tests pass. I will merge the other cleanup PRs for #6676 after review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6676
Rationale for this change
As shown on #6676 (comment), disabling incremental complication saves 2GB of builder space
With incremental compilation enabled (the default):
https://github.com/apache/arrow-datafusion/actions/runs/5281745040/jobs/9555736433?pr=6678
Without incremental compilation: https://github.com/apache/arrow-datafusion/actions/runs/5281960476/jobs/9556242542
Total space used on the builder's filesystem
main (before this PR):
without incremental compilation (this PR):
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?