Skip to content

Comments

fix: type coercion support date - date#6578

Merged
jackwener merged 1 commit intoapache:mainfrom
jackwener:date_minus
Jun 8, 2023
Merged

fix: type coercion support date - date#6578
jackwener merged 1 commit intoapache:mainfrom
jackwener:date_minus

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Jun 7, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

type coercion support date - date

Are these changes tested?

need arrow-rs support it, and then we add slt to test it.

Are there any user-facing changes?

@jackwener jackwener changed the title feat: type coercion support date - date fix: type coercion support date - date Jun 7, 2023
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Jun 7, 2023
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jun 7, 2023
@jackwener
Copy link
Member Author

jackwener commented Jun 7, 2023

wait for arrow-rs support date - date
wait for update arrow-rs new-version

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @jackwener

@jackwener
Copy link
Member Author

Thanks @alamb review

@jackwener jackwener merged commit 9c13a77 into apache:main Jun 8, 2023
@jackwener jackwener deleted the date_minus branch June 8, 2023 03:31
use arrow::datatypes::IntervalUnit::*;
use arrow::datatypes::TimeUnit::*;

if lhs_type == rhs_type {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants