chore(deps): update sqlparser requirement from 0.33 to 0.34#6416
Merged
alamb merged 11 commits intoapache:mainfrom May 23, 2023
Merged
chore(deps): update sqlparser requirement from 0.33 to 0.34#6416alamb merged 11 commits intoapache:mainfrom
alamb merged 11 commits intoapache:mainfrom
Conversation
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.33.0...v0.34.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
github-actions
bot
added
core
viirya
reviewed
May 22, 2023
Comment on lines
+356
to
+361
| let order_by = match order_by.len() { | ||
| 0 => { | ||
| return Err(DataFusionError::NotImplemented( | ||
| "ARRAY_AGG with empty ORDER BY not supported".to_string(), | ||
| )) | ||
| } |
Member
There was a problem hiding this comment.
Hmm isn't ORDER BY an optional clause?
For example, in aggregate_functions.md:
array_agg(expression [ORDER BY expression])
Member
There was a problem hiding this comment.
Oh, nvm, this is the expressions of ORDER BY.
viirya
reviewed
May 22, 2023
viirya
approved these changes
May 22, 2023
Merged
alamb
commented
May 23, 2023
| @@ -404,11 +404,18 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| } | |||
|
|
|||
| Statement::Delete { | |||
Contributor
Author
There was a problem hiding this comment.
This is due to changes in apache/datafusion-sqlparser-rs#855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6407
Rationale for this change
@dependabot did most of the work but the code changes were non trivial enough I wanted to make a separate PR
What changes are included in this PR?
Update sqlparser-rs dependecy
Update datafusion for changes in API (mostly add error about new syntax not being supported)
Are these changes tested?
Yes
Are there any user-facing changes?