Repository navigation
Move ballista standalone mode to client - #589
Merged
Merged
Conversation
Contributor
Author
|
cc @andygrove |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 76.02% 76.08% +0.06%
==========================================
Files 156 158 +2
Lines 27063 27115 +52
==========================================
+ Hits 20575 20631 +56
+ Misses 6488 6484 -4
Continue to review full report at Codecov.
|
andygrove
approved these changes
Jun 18, 2021
jimexist
reviewed
Jun 20, 2021
|
|
||
| # Base image extends debian:buster-slim | ||
| FROM rust:1.51.0-buster AS builder | ||
| FROM rust:1.52.1-buster AS builder |
Contributor
Author
There was a problem hiding this comment.
i have 2 more PRs open. i'll change it in one of the other ones, if that's ok
houqp
approved these changes
Jun 21, 2021
Contributor
Author
|
Build failure seems like a Cargo issue. I've opened rust-lang/cargo#9608. Let's see if they confirm it is a bug or not. |
Contributor
Author
|
@andygrove, this one should be ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #588.
What changes are included in this PR?
Are there any user-facing changes?
Yes, the executor no longer has a --local mode.