Skip to content

Comments

Fix FairSpillPool try_grow for non-spillable consumers#5160

Merged
tustvold merged 1 commit intoapache:masterfrom
tustvold:fix-fair-spill-pool
Feb 2, 2023
Merged

Fix FairSpillPool try_grow for non-spillable consumers#5160
tustvold merged 1 commit intoapache:masterfrom
tustvold:fix-fair-spill-pool

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Feb 2, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Spotted by @xiaoyong-z on #4522 (comment)

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@tustvold tustvold mentioned this pull request Feb 2, 2023
Merged
@github-actions github-actions bot added the core Core DataFusion crate label Feb 2, 2023
alamb
alamb approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold and @xiaoyong-z

@tustvold tustvold merged commit f0c0958 into apache:master Feb 2, 2023
@ursabot
Copy link

ursabot commented Feb 2, 2023

Benchmark runs are scheduled for baseline = b6dbb8d and contender = f0c0958. f0c0958 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

DDtKey pushed a commit to DDtKey/arrow-datafusion that referenced this pull request Feb 2, 2023
@tustvold @DDtKey
Fix FairSpillPool try_grow for non-spillable consumers (apache#5160)
6b817af 
(cherry picked from commit f0c0958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tustvold @ursabot @alamb