Skip to content

Minor: extract sort col rewrite into its own module, add unit tests - #5088

Merged
jackwener merged 2 commits into
apache:masterfrom
alamb:alamb/move_rewrites
Jan 28, 2023
Merged

Minor: extract sort col rewrite into its own module, add unit tests#5088
jackwener merged 2 commits into
apache:masterfrom
alamb:alamb/move_rewrites

Conversation

@alamb

@alamb alamb commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Related to #4854

Rationale for this change

I want to make the code easier to work with as part of the fix and breaking the PR into smaller parts will help with review

What changes are included in this PR?

  1. Move the code into its own module
  2. Add unit tests

No functional change is intended

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions Bot added the logical-expr Logical plan and expressions label Jan 27, 2023
alamb
alamb commented Jan 27, 2023
View reviewed changes
Comment thread datafusion/expr/src/expr_rewriter.rs

/// Rewrite sort on aggregate expressions to sort on the column of aggregate output
/// For example, `max(x)` is written to `col("MAX(x)")`
pub fn rewrite_sort_cols_by_aggs(

@alamb alamb Jan 27, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR just moves this code into a new file and adds some tests

@alamb
alamb marked this pull request as ready for review January 27, 2023 15:27
This was referenced Jan 27, 2023
Merged
Closed
@jackwener

jackwener commented Jan 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR just move code and add some UT. So I will do a quick-merge.

@jackwener
jackwener merged commit a321945 into apache:master Jan 28, 2023
@ursabot

ursabot commented Jan 28, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 7673fcc and contender = a321945. a321945 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
alamb deleted the alamb/move_rewrites branch January 28, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

logical-expr Logical plan and expressions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @jackwener @ursabot