Skip to content

Remove python based posgres comparsion integration-test#5031

Merged
alamb merged 3 commits intoapache:masterfrom
alamb:alamb/remove_integration
Jan 24, 2023
Merged

Remove python based posgres comparsion integration-test#5031
alamb merged 3 commits intoapache:masterfrom
alamb:alamb/remove_integration

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 23, 2023 •
edited
Loading

Which issue does this PR close?

Closes #5011

Rationale for this change

https://github.com/apache/arrow-datafusion/tree/master/integration-tests are now covered by https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sqllogictests/README.md#running-tests-postgres-compatibility as described in #4462

What changes are included in this PR?

Remove integration-test directory and workflow entry

Are these changes tested?

Yes by CI

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Jan 23, 2023
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Jan 23, 2023
@alamb alamb marked this pull request as ready for review January 23, 2023 11:45
@alamb alamb requested a review from jimexist January 23, 2023 11:46
@alamb alamb changed the title Remove python based posgres comparsion function Remove python based posgres comparsion integration-test Jan 23, 2023
@alamb
Copy link
Contributor Author

alamb commented Jan 23, 2023

I plan to leave this open for another day to allow additional time for comments and then will merge it

@alamb alamb merged commit 3f5b834 into apache:master Jan 24, 2023
@alamb alamb deleted the alamb/remove_integration branch January 24, 2023 22:36
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = cb05490 and contender = 3f5b834. 3f5b834 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jimexist
Copy link
Member

jimexist commented Jan 25, 2023

Thank you - less code happier me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xudong963 xudong963 xudong963 approved these changes

@jimexist jimexist Awaiting requested review from jimexist

+1 more reviewer

@melgenek melgenek melgenek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sqllogictest] Remove integration-tests directory

5 participants

@alamb @ursabot @jimexist @melgenek @xudong963