Repository navigation
Update sqlparser requirement from 0.27 to 0.28 - #4568
Merged
Merged
Conversation
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases) - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
github-actions
Bot
added
core
alamb
commented
Dec 9, 2022
| match *source.body { | ||
| SetExpr::Values(values) => { | ||
| insert_values = values.0.clone(); | ||
| insert_values = values.rows; |
Contributor
Author
There was a problem hiding this comment.
FYI @xudong963 I think I was able to avoid a clone in the sqllogictests (not that it makes a huge difference)
This was referenced Dec 9, 2022
Contributor
Author
|
I am going to merge this in to unblock other work upstream. cc @waitingkuo @sarahyurick @jackwener |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4523
re #3944
Rationale for this change
Get latest sqlparser to keep up with dependencies and get fix for #3944
What changes are included in this PR?
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
maybe #3944 is fixed. I will make a subsequent PR with some tests to cover that case