Skip to content

sqllogictest: A logging and command line filter#4497

Merged
alamb merged 6 commits intoapache:masterfrom
alamb:alamb/one_test_file
Dec 5, 2022
Merged

sqllogictest: A logging and command line filter#4497
alamb merged 6 commits intoapache:masterfrom
alamb:alamb/one_test_file

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 4, 2022 •
edited
Loading

Which issue does this PR close?

re #4460

Rationale for this change

While debugging a sqllogictest I would like to run a single file at a time rather than all in the directory. I would also like the ability to see debug logs, etc, etc

What changes are included in this PR?

  1. Initialize env_logger so setting RUST_LOG is respted
  2. Add ability to specify files on the command line,
  3. Documentation

Note, I did not bring in Clap or some other full featured command line parser. I figured if/when we need the ability to add more flags, we could bring it in.

Also I tried to avoid making changes that would conflict with #4496 from @xudong963

Are these changes tested?

Are there any user-facing changes?

No

Examples

Example running with just one file:

cargo test -p datafusion --test sqllogictests -- information_schema.slt

Running: tests/sqllogictests/test_files/information_schema.slt
Enabling information schema
[information_schema.slt] Running query: "SHOW ALL"
[information_schema.slt] Running query: "SHOW datafusion.execution.batch_size"
[information_schema.slt] Running query: "SHOW TIME ZONE"
[information_schema.slt] Running query: "SHOW TIMEZONE"

Example with logging:

RUST_LOG=debug cargo test -p datafusion --test sqllogictests -- information_schema.slt

[2022-12-04T12:30:03Z INFO  sqllogictests] Test directory: tests/sqllogictests/test_files
[2022-12-04T12:30:03Z INFO  sqllogictests] Running test files ["tests/sqllogictests/test_files/information_schema.slt"]
Running: tests/sqllogictests/test_files/information_schema.slt
Enabling information schema
[2022-12-04T12:30:03Z DEBUG datafusion::execution::memory_manager] Creating memory manager with initial size 11744051.2 TB
[information_schema.slt] Running query: "SHOW ALL"
[2022-12-04T12:30:03Z DEBUG sqlparser::parser] parsing expr
[2022-12-04T12:30:03Z DEBUG sqlparser::parser] prefix: Identifier(Ident { value: "name", quote_style: None })
[2022-12-04T12:30:03Z DEBUG sqlparser::parser] get_next_precedence() Comma
[2022-12-04T12:30:03Z DEBUG sqlparser::parser] 0: , 1: setting 2: FROM
....

@github-actions github-actions bot added the core Core DataFusion crate label Dec 4, 2022
@alamb alamb force-pushed the alamb/one_test_file branch from 18bec3b to 42af19e Compare December 4, 2022 12:37
@xudong963 xudong963 mentioned this pull request Dec 4, 2022
Merged
@alamb alamb mentioned this pull request Dec 4, 2022
Closed
28 tasks
@alamb alamb marked this pull request as ready for review December 4, 2022 15:05
@alamb
Copy link
Contributor Author

alamb commented Dec 4, 2022 •
edited
Loading

cc @xudong963 and @mvanschellebeeck

mvanschellebeeck
mvanschellebeeck reviewed Dec 4, 2022
View reviewed changes
mvanschellebeeck
mvanschellebeeck reviewed Dec 4, 2022
View reviewed changes
@mvanschellebeeck
Copy link
Contributor

mvanschellebeeck commented Dec 4, 2022

nice - thanks @alamb!

xudong963
xudong963 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a very nice feature, we don't need to run all tests each time. Thank you @alamb

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 5, 2022
@alamb alamb merged commit 2a754f8 into apache:master Dec 5, 2022
@alamb alamb deleted the alamb/one_test_file branch December 5, 2022 18:53
@ursabot
Copy link

ursabot commented Dec 5, 2022

Benchmark runs are scheduled for baseline = 237233f and contender = 2a754f8. 2a754f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xudong963 xudong963 xudong963 approved these changes

+1 more reviewer

@mvanschellebeeck mvanschellebeeck mvanschellebeeck left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @mvanschellebeeck @ursabot @xudong963