MINOR: enable dyn_cmp_dict feature on arrow for physical expr crate#4163
MINOR: enable dyn_cmp_dict feature on arrow for physical expr crate#4163alamb merged 1 commit intoapache:masterfrom
dyn_cmp_dict feature on arrow for physical expr crate#4163Conversation
|
Can we only enable this for dev, dyn_cmp_dict is an extremely heavy feature that is intentionally not enabled by default? |
462ff0f to
927bade
Compare
Makes sense @tustvold, I've changed the PR to only enable it as part of the dev dependencies. |
|
Benchmark runs are scheduled for baseline = 456c254 and contender = 36890b8. 36890b8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Seems like when we are executing the test suite for the physical exprs in a standalone way (which I tend to do quite a lot 😄), it fails with a test requiring a specific feature from
arrow-rs(dyn_cmp_dict). It is already turned on fordatafusion-core, so ideally this should not change anything.