Skip to content

Update SQL reference to state that decimal support is currently experimental - #4109

Merged
andygrove merged 6 commits into
apache:masterfrom
andygrove:decimal-docs
Nov 7, 2022
Merged

Update SQL reference to state that decimal support is currently experimental#4109
andygrove merged 6 commits into
apache:masterfrom
andygrove:decimal-docs

Conversation

@andygrove

@andygrove andygrove commented Nov 4, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #4036

Rationale for this change

We don't want users to be surprised

What changes are included in this PR?

Update SQL reference to state that decimal support is currently experimental

Are there any user-facing changes?

@andygrove
andygrove marked this pull request as ready for review November 4, 2022 13:57
alamb
alamb approved these changes Nov 4, 2022
View reviewed changes

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me but I think @liukun4515 should weigh in here prior to merging

HaoYang670
HaoYang670 approved these changes Nov 5, 2022
View reviewed changes

@HaoYang670 HaoYang670 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small nit.

Comment thread docs/source/user-guide/sql/data_types.md Resolved
liukun4515
liukun4515 approved these changes Nov 7, 2022
View reviewed changes

@liukun4515 liukun4515 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb

alamb commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

I took the liberty of merging from master and running prettier (in ca79643) so we could get this PR merged and out of the backlog

@andygrove
andygrove merged commit b9eee50 into apache:master Nov 7, 2022
@andygrove
andygrove deleted the decimal-docs branch November 7, 2022 23:31
@ursabot

ursabot commented Nov 7, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 7b5842b and contender = b9eee50. b9eee50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes
@liukun4515 liukun4515 liukun4515 approved these changes
+1 more reviewer
@HaoYang670 HaoYang670 HaoYang670 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add documentation to make it clear that decimal support is still experimental

5 participants

@andygrove @alamb @ursabot @liukun4515 @HaoYang670