Skip to content

Comments

MINOR: Stop ignoring AggregateFunction::distinct in protobuf serde code#3250

Merged
andygrove merged 3 commits intoapache:masterfrom
andygrove:agg-fun-distinct
Aug 24, 2022
Merged

MINOR: Stop ignoring AggregateFunction::distinct in protobuf serde code#3250
andygrove merged 3 commits intoapache:masterfrom
andygrove:agg-fun-distinct

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Aug 24, 2022

Which issue does this PR close?

N/A

Rationale for this change

We should not have hard-coded values for distinct. We should use the intended values, otherwise queries could return the wrong results.

What changes are included in this PR?

Remove hard-coded distinct values and add tests.

Are there any user-facing changes?

Yes, fixes some incorrect query results.

@github-actions github-actions bot added the optimizer Optimizer rules label Aug 24, 2022
@andygrove andygrove changed the title MINOR: Remove hard-coded values for distinct in aggregate function handling MINOR: Stop ignoring AggregateFunction::distinct in protobuf serde code Aug 24, 2022
@andygrove andygrove marked this pull request as ready for review August 24, 2022 16:14
@andygrove andygrove added the bug Something isn't working label Aug 24, 2022
This was referenced Aug 24, 2022
Closed
Merged
@andygrove
Copy link
Member Author

andygrove commented Aug 24, 2022

fyi @yahoNanJing @thinkharderdev @avantgardnerio @mingmwang @Ted-Jiang since this probably affects Ballista?

@andygrove andygrove mentioned this pull request Aug 24, 2022
Merged
@andygrove andygrove merged commit 7e407df into apache:master Aug 24, 2022
@andygrove andygrove deleted the agg-fun-distinct branch August 24, 2022 23:12
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = 6c32098 and contender = 7e407df. 7e407df is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkharderdev thinkharderdev thinkharderdev approved these changes

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working optimizer Optimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andygrove @ursabot @thinkharderdev @avantgardnerio