Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2786 +/- ##
==========================================
- Coverage 85.15% 85.11% -0.04%
==========================================
Files 273 273
Lines 48076 48096 +20
==========================================
Hits 40938 40938
- Misses 7138 7158 +20
Continue to review full report at Codecov.
|
| "epoch" => extract_date_part!(array, extract_epoch), | ||
| _ => Err(DataFusionError::Execution(format!( | ||
| "Date part '{}' not supported", | ||
| "Date partx '{}' not supported", |
There was a problem hiding this comment.
| "Date partx '{}' not supported", | |
| "Date part '{}' not supported", |
| if array.is_null(i) { | ||
| b.append_null()?; | ||
| } else { | ||
| let scale = match unit { |
There was a problem hiding this comment.
I would recommend using the chrono functions for this, such as done here:
| T: ArrowTemporalType + ArrowNumericType, | ||
| i64: std::convert::From<T::Native>, | ||
| { | ||
| let mut b = Int32Builder::new(array.len()); |
There was a problem hiding this comment.
Note: In terms of performance (and readability), it is better to avoid the builder/value etc. and work directly on the values (check the arrow-rs kernels for examples).
Ok to leave this for a future PR if you like 👍
|
This PR is more than 6 month old, so closing it down for now to clean up the PR list. Please reopen if this is a mistake and you plan to work on it more |
Which issue does this PR close?
Closes #2785
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?