Repository navigation
fix: TopK aggregation now uses indices instead of column names for computed projections - #27430
Open
vikrantmehta123 wants to merge 2 commits into
Open
vikrantmehta123 wants to merge 2 commits into
vikrantmehta123 wants to merge 2 commits into
Conversation
… reusing the aggregate's name
…euses the aggregate's name
github-actions
Bot
added
optimizer
Contributor
Author
|
Hi @jayzhan211, a question on the scope. In this PR, I changed only the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR fixes a query correctness bug. The issue details the bug.
What changes are included in this PR?
Previously,
TopKAggregationfollowed the sort key through projections by name and skipped computed expressions. This caused the issue that if a computed expression was aliased to the aggregate's name, the rule could not distinguish the two.datafusion/physical-optimizer/src/topk_aggregation.rs: the projection arm no longer loops over every expression to match on the name. It looks up the expression at the sort column's index. If that expression is not a plainColumnthen the optimization won't be applied.What is the testing strategy for this PR?
Two SLTs are added in
datafusion/sqllogictest/test_files/aggregates_topk.slt. One covers the query result and the other covers the query plans. The query used in the SLTs is the one from the issue."Tests were run before applying the fix to ensure that the bug exists and the tests catch the bug.
Are there any user-facing changes?
Yes, the query now returns correct output. No change in the public APIs.