Repository navigation
chore: remove cargo check datafusion-spark features from required checks - #27375
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
the
development-process
The check is no longer required, so check_rust_workflow_skips.py no longer allows it to skip on pushes to main. Co-Authored-By: Claude Opus 5.5 <[email protected]>
alamb
approved these changes
Nov 12, 2026
| name: cargo check datafusion-spark features | ||
| needs: linux-build-lib | ||
| if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} | ||
| if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} |
Contributor
There was a problem hiding this comment.
why is the repository = 'apache/datafusion' check removed?
Contributor
There was a problem hiding this comment.
I guess it doesn't matter as this will be deleted #27337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkcrate (moving to apache/datafusion-spark) #27337.Rationale for this change
#27337 removes the
datafusion-sparkcrate, along with thecargo check datafusion-spark featuresCI job. ASF applies branch protection from the.asf.yamlonmain, so while that check is still listed there, #27337 can't merge: the check it's waiting on never runs.What changes are included in this PR?
cargo check datafusion-spark featuresfromrequired_status_checksin.asf.yaml.POST_MERGE_SKIPPED_JOBSincheck_rust_workflow_skips.py. The script only lets required checks skip on pushes tomain, because the merge queue only runs required checks.if:inrust.yml. The same script requires each job'sif:to match its skip sets exactly, so leaving the job out ofPOST_MERGE_SKIPPED_JOBSmeans itsif:keeps only the fork-PR clause.As a result, the job runs on pushes to
mainagain until #27337 removes it. It is no longer required, so it can't block anything.What is the testing strategy for this PR?
The
Validate required_status_checks in .asf.yamlCI check, which runscheck_asf_yaml_status_checks.py,check_rust_workflow_skips.pyandtest_rust_workflow_skips.py. All three pass locally.Are there any user-facing changes?
No.
🤖 Generated with Claude Code