Repository navigation
Conversation
github-actions
Bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Offset zero selects the current row, so a NULL current value must remain NULL rather than produce the default.
What changes are included in this PR?
The fix aligns the stateful evaluator with
evaluate_all_with_ignore_nullfor zero-offsetLEAD/LAG.What is the testing strategy for this PR?
The new regression covers
LEADandLAG, nonzero offsets, and batch evaluation, including NULL and non-NULL current rows with and without defaults.All 9 window SQL logic test files passed. Workspace Clippy passed with
-D warnings.Are there any user-facing changes?
Zero-offset
LEAD/LAG IGNORE NULLSnow preserves a NULL current value.