Repository navigation
fix: validate column-specific parquet encoding - #27275
Open
vinycalves wants to merge 1 commit into
Open
vinycalves wants to merge 1 commit into
vinycalves wants to merge 1 commit into
Conversation
github-actions
Bot
added
common
vinycalves
force-pushed
the
fix/parquet-column-encoding
branch
from
November 9, 2026 21:44
17e74cf to
b00f438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17498. This is the column-specific follow-up to #25784: the global parquet encoding is validated when it is set, but ParquetColumnOptions.encoding still stores a string, so an invalid format.encoding::column is only rejected when a write starts. This changes the field to the existing DFParquetEncoding, updates both proto conversion paths, and adds tests for valid and invalid values. The relevant tests in datafusion-common, datafusion-proto-common and datafusion-proto-models pass, and clippy is clean. Because ParquetColumnOptions.encoding changes from an optional string to the DFParquetEncoding enum, this needs the api change label.