Repository navigation
Conversation
Member
|
Heads-up: as discussed in apache/datafusion-spark#87, we plan to move the This PR changes |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses apache/datafusion-spark#46 by adding selectable Spark 4-compatible behavior to the
datafusion-sparkencodeexpression.datafusion.spark.legacy_java_charsetsanddatafusion.spark.legacy_coding_error_action, both defaulting tofalse.legacy_java_charsetsis enabled.MALFORMED_CHARACTER_CODING(SQLSTATE22000) for unmappable characters by default.legacy_coding_error_actionis enabled.Validation
cargo check -p datafusion-spark -p datafusion-commoncargo clippy -p datafusion-spark -p datafusion-common -- -D warningscargo fmt --checkdatafusion-sparklibrary tests (333 passed)encode.sltSQLLogicTestinformation_schema.sltSQLLogicTestgit diff HEAD^ HEAD --checkCompatibility note
The existing empty-input UTF-16 behavior is unchanged: DataFusion emits the UTF-16 BOM, whereas Spark returns an empty byte array. This pre-existing divergence is documented and retained.
Closes apache/datafusion-spark#46.